Implement review suggestions

h2oai · Sep 22, 2023 · 7258fa9 · 7258fa9
1 parent 72b2298
commit 7258fa9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/h2o-algos/src/main/java/hex/schemas/AdaBoostV3.java b/h2o-algos/src/main/java/hex/schemas/AdaBoostV3.java
@@ -29,7 +29,7 @@ public static final class AdaBoostParametersV3 extends ModelParametersSchemaV3<A
         @API(help = "Number of AdaBoost weak learners.", gridable = true)
         public int nlearners;
 
-        @API(help = "Choose a weak learner type. Defaults to DRF.", gridable = true, values = {"AUTO", "DRF", "GLM", "GBM"})
+        @API(help = "Choose a weak learner type. Defaults to AUTO, which means DRF.", gridable = true, values = {"AUTO", "DRF", "GLM", "GBM"})
         public AdaBoostModel.Algorithm weak_learner;
 
         @API(help="Learning rate (from 0.0 to 1.0)", gridable = true)

diff --git a/h2o-bindings/bin/gen_R.py b/h2o-bindings/bin/gen_R.py
@@ -272,7 +272,7 @@ def algo_to_modelname(algo):
     if algo == "gam": return "Generalized Additive Model"
     if algo == "modelselection": return "Model Selection"
     if algo == "infogram": return "Infogram"
-    if algo == "adaboost": return "AdaBoost Model in H2O"
+    if algo == "adaboost": return "AdaBoost Model"
     return algo
 
 

diff --git a/h2o-py/h2o/estimators/adaboost.py b/h2o-py/h2o/estimators/adaboost.py
@@ -62,7 +62,7 @@ def __init__(self,
         :param nlearners: Number of AdaBoost weak learners.
                Defaults to ``50``.
         :type nlearners: int
-        :param weak_learner: Choose a weak learner type. Defaults to DRF.
+        :param weak_learner: Choose a weak learner type. Defaults to AUTO, which means DRF.
                Defaults to ``"auto"``.
         :type weak_learner: Literal["auto", "drf", "glm", "gbm"]
         :param learn_rate: Learning rate (from 0.0 to 1.0)
@@ -178,7 +178,7 @@ def nlearners(self, nlearners):
     @property
     def weak_learner(self):
         """
-        Choose a weak learner type. Defaults to DRF.
+        Choose a weak learner type. Defaults to AUTO, which means DRF.
 
         Type: ``Literal["auto", "drf", "glm", "gbm"]``, defaults to ``"auto"``.
         """

diff --git a/h2o-r/h2o-package/R/adaboost.R b/h2o-r/h2o-package/R/adaboost.R
@@ -1,7 +1,7 @@
 # This file is auto-generated by h2o-3/h2o-bindings/bin/gen_R.py
 # Copyright 2016 H2O.ai;  Apache License Version 2.0 (see LICENSE for details) 
 #'
-# -------------------------- AdaBoost Model in H2O -------------------------- #
+# -------------------------- AdaBoost Model -------------------------- #
 #'
 #' Build an AdaBoost model
 #' 
@@ -25,7 +25,8 @@
 #'        you set weight = 0 for a row, the returned prediction frame at that row is zero and this is incorrect. To get
 #'        an accurate prediction, remove all rows with weight == 0.
 #' @param nlearners Number of AdaBoost weak learners. Defaults to 50.
-#' @param weak_learner Choose a weak learner type. Defaults to DRF. Must be one of: "AUTO", "DRF", "GLM", "GBM". Defaults to AUTO.
+#' @param weak_learner Choose a weak learner type. Defaults to AUTO, which means DRF. Must be one of: "AUTO", "DRF", "GLM", "GBM".
+#'        Defaults to AUTO.
 #' @param learn_rate Learning rate (from 0.0 to 1.0) Defaults to 0.5.
 #' @param seed Seed for random numbers (affects certain parts of the algo that are stochastic and those might or might not be enabled by default).
 #'        Defaults to -1 (time-based random number).