Fix tests related to new adaboost API

h2oai · Sep 8, 2023 · f03c3b9 · f03c3b9
1 parent 7908349
commit f03c3b9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/h2o-algos/src/main/java/hex/adaboost/AdaBoostModel.java b/h2o-algos/src/main/java/hex/adaboost/AdaBoostModel.java
@@ -23,7 +23,7 @@ public ModelMetrics.MetricBuilder makeMetricBuilder(String[] domain) {
         if (_output.getModelCategory() == ModelCategory.Binomial) {
             return new ModelMetricsBinomial.MetricBuilderBinomial(domain);
         }
-        throw H2O.unimpl();
+        throw H2O.unimpl("AdaBoost currently support only binary classification");
     }
 
     @Override

diff --git a/h2o-py/tests/testdir_sklearn/pyunit_sklearn_generic_all_estimators.py b/h2o-py/tests/testdir_sklearn/pyunit_sklearn_generic_all_estimators.py
@@ -199,6 +199,7 @@ def make_tests(classifier):
     'H2OWord2vecEstimator',  # needs a separate test (requires pre_trained model as parameter)
     'H2OUpliftRandomForestEstimator',  # generic part is not implemented yet
     'H2ODecisionTreeEstimator',  # generic part is not implemented yet
+    'H2OAdaBoostEstimator',  # generic part is not implemented yet or test needs to be adjusted just for classification
 ]
 estimators = [cls for name, cls in inspect.getmembers(h2o.sklearn, inspect.isclass)
               if name.endswith('Estimator') and name not in ['H2OAutoMLEstimator'] + failing]

diff --git a/h2o-py/tests/testdir_sklearn/pyunit_sklearn_regression_all_estimators.py b/h2o-py/tests/testdir_sklearn/pyunit_sklearn_regression_all_estimators.py
@@ -139,6 +139,7 @@ def make_tests(classifier):
     'H2OStackedEnsembleRegressor',  # needs a separate test (requires models as parameters),
     'H2OUpliftRandomForestRegressor',  # does not support regression yet
     'H2ODecisionTreeRegressor'  # does not support regression yet
+    'H2OAdaBoostRegressor'  # does not support regression yet
 ]
 regressors = [cls for name, cls in inspect.getmembers(h2o.sklearn, inspect.isclass)
               if name.endswith('Regressor') and name not in ['H2OAutoMLRegressor']+failing]