-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace run.skip-xxx
options by issues.exclude-xxx
options
#4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b1cfe1
to
ad09dde
Compare
alexandear
reviewed
Mar 15, 2024
894fabc
to
5de9d08
Compare
alexandear
approved these changes
Mar 15, 2024
2b038c9
to
a69b8b6
Compare
a69b8b6
to
ceef5f7
Compare
ceef5f7
to
7b2fd9f
Compare
bombsimon
reviewed
Mar 16, 2024
bombsimon
reviewed
Mar 16, 2024
bombsimon
approved these changes
Mar 16, 2024
lunny
pushed a commit
to go-gitea/gitea
that referenced
this pull request
Apr 11, 2024
Update and adapt to one setting [deprecation](golangci/golangci-lint#4509).
5 tasks
9 tasks
6 tasks
deadlycoconuts
added a commit
to caraml-dev/merlin
that referenced
this pull request
Feb 18, 2025
# Description This PR simply removes a deprecated config field in the golangci config file and replaces it with its replacement. See this CICD run for an example of a failed run: https://github.com/caraml-dev/merlin/actions/runs/13383384346/job/37376991624#step:4:35. Previously using the old config would only emit warnings but now they have become explicit errors. See this PR from golangci for more details golangci/golangci-lint#4509. # Modifications - `api/.golangci.yml` - Replace deprecated configs # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note NONE ```
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: config
Related to .golangci.yml and/or cli options
area: exclusions
enhancement
New feature or improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option name
skip-xxx
is a source of confusion.And to increase the confusion, those options are inside the section
run
.This sample of issues illustrate the problem: #1912, #2748, #4084, #3775, #1832, #4360
My proposal is move and rename those options:
run.skip-dirs
deprecation: replaced byissues.exclude-dirs
run.skip-dirs-use-default
deprecation: replaced byissues.exclude-dirs-use-default
run.skip-files
deprecation: replaced byissues.exclude-files
This is a non-breaking change: the
skip-xxx
will still work but with a warning, andissues.exclude-xxx
options do the same things asskip-xxx
.log output
Using a flag:
Using the file:
one commit, one change.