-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign bundle manifest excluding certain fields and add the signature as an annotation #9150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9150 +/- ##
=======================================
Coverage 72.37% 72.37%
=======================================
Files 585 585
Lines 45708 45708
=======================================
Hits 33082 33082
Misses 10888 10888
Partials 1738 1738 ☔ View full report in Codecov by Sentry. |
29c8ecf
to
c159791
Compare
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c159791
to
85a7667
Compare
/unhold |
85a7667
to
63ccf56
Compare
@@ -54,6 +54,6 @@ const ( | |||
// (January 2, 15:04:05, 2006, in time zone seven hours west of GMT). | |||
YYYYMMDD = "2006-01-02" | |||
|
|||
MAX_IMAGES_PER_REPOSITORY = 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just to make the Go code idiomatic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
63ccf56
to
81410a5
Compare
Issue #, if available:
#2855
Description of changes:
This PR adds bundle manifest signing to the EKS-A release CLI to prevent tampering for extended kubernetes version support and also adds the signature as an annotation to the bundle so that it can be fetched by the controller for signature verification.
This PR also fixes all the lint errors in the release folder. Following are the most common lint errors:
The second and third errors have been ignored by using
//nolint:revive
comment.Testing (if applicable):
Ran the following commands from the root folder:
Verified that the generated bundle manifest has the expected annotations:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.