fix(cicd): Replace deprecated golangci config #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
requested review from
bthari,
mbruner,
naufalandika,
shydefoo and
vinoth-gojek
bthari
approved these changes
Feb 18, 2025
|
Thanks for the quick review! Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply removes a deprecated config field in the golangci config file and replaces it with its replacement. See this CICD run for an example of a failed run: https://github.com/caraml-dev/merlin/actions/runs/13383384346/job/37376991624#step:4:35. Previously using the old config would only emit warnings but now they have become explicit errors. See this PR from golangci for more details golangci/golangci-lint#4509.
Modifications
api/.golangci.yml- Replace deprecated configsTests
Checklist
Release Notes