Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disallow starting continuous profiler if SDK is closed #4961

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

armcknight
Copy link
Member

It already worked that way, but we didn't have a test explicitly for it.

#skip-changelog

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.517%. Comparing base (c964075) to head (2072277).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4961       +/-   ##
=============================================
+ Coverage   92.470%   92.517%   +0.047%     
=============================================
  Files          666       666               
  Lines        78926     78960       +34     
  Branches     28572     28606       +34     
=============================================
+ Hits         72983     73052       +69     
+ Misses        5845      5811       -34     
+ Partials        98        97        -1     
Files with missing lines Coverage Δ
Tests/SentryTests/SentrySDKTests.swift 97.078% <100.000%> (+0.087%) ⬆️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c964075...2072277. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tests are failing, probably requires compiler flags for checking if startProfiler is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants