Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format: remove all leading whitespace on empty lines #4963

Open
wants to merge 1 commit into
base: armcknight/test/starting-continuous-profiler-with-closed-sdk
Choose a base branch
from

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Mar 8, 2025

I got tripped up because somehow a ton of these lines got edited in my Xcode while I prepared #4961 and is still causing me pain in #4855. i decided it'd just be easiest to wipe them out across the codebase and add the lint rule to prevent them from creeping back in.

I recommend enabling the trim whitespace-only lines option in Xcode or equivalent IDE (it wasn't previously enabled for me so I don't know why they got trimmed in the first place):

image

#skip-changelog

@armcknight armcknight changed the title remove all leading whitespace on empty lines format: remove all leading whitespace on empty lines Mar 8, 2025
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 96.57185% with 47 lines in your changes missing coverage. Please review.

Project coverage is 92.504%. Comparing base (2072277) to head (ea4c35d).

Files with missing lines Patch % Lines
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% 20 Missing ⚠️
...tryUserFeedbackWidgetButtonMegaphoneIconView.swift 0.000% 6 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 5 Missing ⚠️
Sources/SentrySwiftUI/SentryTracedView.swift 42.857% 4 Missing ⚠️
Sources/Swift/Helper/SentryIconography.swift 55.555% 4 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 4 Missing ⚠️
...serFeedback/SentryUserFeedbackFormController.swift 33.333% 2 Missing ⚠️
SentryTestUtils/TestTransport.swift 0.000% 1 Missing ⚠️
...UserFeedback/SentryUserFeedbackFormViewModel.swift 97.222% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                                        Coverage Diff                                         @@
##           armcknight/test/starting-continuous-profiler-with-closed-sdk     #4963       +/-   ##
==================================================================================================
- Coverage                                                        92.517%   92.504%   -0.013%     
==================================================================================================
  Files                                                               666       666               
  Lines                                                             78960     78958        -2     
  Branches                                                          28606     28600        -6     
==================================================================================================
- Hits                                                              73052     73040       -12     
- Misses                                                             5811      5820        +9     
- Partials                                                             97        98        +1     
Files with missing lines Coverage Δ
SentryTestUtils/BreadcrumbExtension.swift 100.000% <100.000%> (ø)
SentryTestUtils/ClearTestState.swift 86.363% <100.000%> (ø)
SentryTestUtils/Invocations.swift 86.956% <ø> (ø)
SentryTestUtils/SentryLogExtensions.swift 100.000% <ø> (ø)
SentryTestUtils/TestClient.swift 85.714% <ø> (ø)
SentryTestUtils/TestConstants.swift 100.000% <ø> (ø)
SentryTestUtils/TestDebugImageProvider.swift 72.727% <100.000%> (ø)
SentryTestUtils/TestDisplayLinkWrapper.swift 95.959% <100.000%> (ø)
SentryTestUtils/TestFramesTracker.swift 100.000% <ø> (ø)
SentryTestUtils/TestHub.swift 60.000% <100.000%> (ø)
... and 211 more

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2072277...ea4c35d. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.18 ms 1247.11 ms 30.92 ms
Size 22.30 KiB 823.45 KiB 801.14 KiB

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this! It also started to bother me.

As the amount of files is massive, I used the "Hide whitespace" feature of GitHub review to show only non-whitespace changes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants