-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): new start and stop API #4855
base: armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch
Are you sure you want to change the base?
feat(profiling): new start and stop API #4855
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch #4855 +/- ##
=======================================================================================================
+ Coverage 92.470% 92.506% +0.036%
=======================================================================================================
Files 666 666
Lines 78926 78993 +67
Branches 28572 28599 +27
=======================================================================================================
+ Hits 72983 73074 +91
+ Misses 5845 5820 -25
- Partials 98 99 +1
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b81c36b | 1229.65 ms | 1252.16 ms | 22.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b81c36b | 22.30 KiB | 823.44 KiB | 801.13 KiB |
Previous results on branch: armcknight/profiling/new-continuous-apis/2-new-start-stop-api
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c760c84 | 1221.76 ms | 1243.46 ms | 21.70 ms |
6f57ac5 | 1230.02 ms | 1244.73 ms | 14.71 ms |
6b4657c | 1215.92 ms | 1236.57 ms | 20.65 ms |
96e7192 | 1206.88 ms | 1235.85 ms | 28.97 ms |
468d437 | 1228.67 ms | 1250.08 ms | 21.41 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c760c84 | 22.30 KiB | 823.68 KiB | 801.38 KiB |
6f57ac5 | 22.32 KiB | 819.64 KiB | 797.32 KiB |
6b4657c | 22.32 KiB | 819.64 KiB | 797.32 KiB |
96e7192 | 22.30 KiB | 822.04 KiB | 799.74 KiB |
468d437 | 22.30 KiB | 822.04 KiB | 799.73 KiB |
2888371
to
3b04d2d
Compare
a09d3e7
to
537c49d
Compare
3b04d2d
to
29e5d36
Compare
…w to deal with the deprecated usage in SentryEnabledFeaturesBuilder
29e5d36
to
5b002e0
Compare
537c49d
to
52a2d68
Compare
2990aba
to
d49fbd0
Compare
d49fbd0
to
11a6de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this doesn't get merged to main, the TODOs are OK, LGTM
…d-sdk' into armcknight/git-chain/profiling/new-continuous-apis/2-new-start-stop-api
…s-apis/0-topic-branch
…pic-branch' into armcknight/git-chain/profiling/new-continuous-apis/2-new-start-stop-api
…pic-branch' into armcknight/git-chain/profiling/new-continuous-apis/2-new-start-stop-api
…d-sdk' into armcknight/git-chain/profiling/new-continuous-apis/2-new-start-stop-api
b7d9f5a
to
48bb10b
Compare
stub the new start and stop methods we'll offer for continuous profiling. there are some TODOs for checks that come in later PR branches as those API are implemented and become available.
#skip-changelog; for #4853