Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml, fix gz sdf tests on Windows #1374

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Add package.xml, fix gz sdf tests on Windows #1374

merged 11 commits into from
Apr 19, 2024

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Feb 24, 2024

🎉 New feature

Summary

Add package.xml based on dependencies found in .github/ci/packages.

This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from scpeters as a code owner February 24, 2024 00:04
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Feb 24, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (ff9b3ad) to head (25bc68a).
Report is 9 commits behind head on sdf14.

❗ Current head 25bc68a differs from pull request most recent head 48b5031. Consider uploading reports for the commit 48b5031 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            sdf14    #1374   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         134      134           
  Lines       17751    17751           
=======================================
  Hits        16406    16406           
  Misses       1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is unhappy

@azeey
Copy link
Collaborator Author

azeey commented Apr 19, 2024

Needs gazebosim/gz-tools#140 to fix windows.

@azeey azeey mentioned this pull request Apr 19, 2024
8 tasks
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, maybe retitle to Add package.xml, fix gz sdf on Windows?

@azeey azeey changed the title Add package.xml Add package.xml, fix gz sdf tests on Windows Apr 19, 2024
@azeey azeey merged commit 3e93e68 into sdf14 Apr 19, 2024
11 checks passed
@azeey azeey deleted the package_xml branch April 19, 2024 20:13
azeey added a commit to azeey/sdformat that referenced this pull request May 7, 2024
The `gz sdf` tests are fixed by
* fixing dll path issue with Ruby on windows
* Setting home path

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters pushed a commit that referenced this pull request May 10, 2024
Partially backports #1374 to fix #1321
* Add package.xml, fix `gz sdf` tests on Windows (#1374)
  The `gz sdf` tests are fixed by
    * fixing dll path issue with Ruby on windows
    * Setting home path
* Fix macOS workflow

Signed-off-by: Addisu Z. Taddese <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
The `gz sdf` tests are fixed by 
* fixing dll path issue with Ruby on windows
* Setting home path

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
The `gz sdf` tests are fixed by 
* fixing dll path issue with Ruby on windows
* Setting home path

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants