Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dll search paths for Ruby on Windows #140

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 19, 2024

🦟 Bug fix

Summary

The version of Ruby we use in our CI comes from https://rubyinstaller.org/, which according to their wiki says that the PATH environment variable is ignored when searching for dlls. This has been one of the reasons the gz tool doesn't work on Windows in our CI. This patch fixes it by setting RUBY_DLL_PATH equal to PATH.

Needed by gazebosim/sdformat#1374

Successful build in Build Status

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner April 19, 2024 16:54
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic labels Apr 19, 2024
@azeey azeey merged commit 0598036 into gz-tools2 Apr 19, 2024
10 checks passed
@azeey azeey deleted the azeey/fix_rubyinstaller branch April 19, 2024 17:49
azeey added a commit that referenced this pull request Apr 19, 2024
azeey added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants