Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix dll search paths for Ruby on Windows (#140) #141

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 19, 2024

Backport

Backporting #140

Note to maintainers: Remember to Rebase

@azeey azeey requested a review from caguero as a code owner April 19, 2024 18:36
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 19, 2024
@azeey
Copy link
Contributor Author

azeey commented Apr 22, 2024

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

@scpeters
Copy link
Member

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

@scpeters
Copy link
Member

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

I just updated the required job listing for the ign-tools1 branch to require focal and not require jammy

@azeey
Copy link
Contributor Author

azeey commented Apr 23, 2024

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

I just updated the required job listing for the ign-tools1 branch to require focal and not require jammy

Okay, I wasn't sure if the branch requirement was there before we started using gz-collections.yaml, so I thought it might be a bug in the transition.

@azeey azeey merged commit 2c9212b into ign-tools1 Apr 23, 2024
9 checks passed
@azeey azeey deleted the azeey/fix_rubyinstaller branch April 23, 2024 13:52
@azeey
Copy link
Contributor Author

azeey commented Apr 23, 2024

Argh, I should have Rebase merged this. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants