Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9 ➡️ 12 #1087

Merged
merged 5 commits into from
Jul 22, 2022
Merged

9 ➡️ 12 #1087

merged 5 commits into from
Jul 22, 2022

Conversation

jennuine
Copy link
Collaborator

➡️ Forward port

Port sdf9 to sdf12

Branch comparison: sdf12...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters and others added 4 commits May 23, 2022 11:47
@scpeters
Add Link::ResolveInertial API (#1012)
a428e2a 
The Link::Inertial() method returns an Inertial object with a Pose
specified relative to the link frame. This adds a new method for
resolving the Inertial's Pose to a specified frame. The method
is demonstrated in the `ign sdf --inertial-states` command code.

Fixed #935.

Signed-off-by: Steve Peters <[email protected]>
@mabelzhang @chapulina
Bash completion for flags (#1042)
9fc2e5f 
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@scpeters
Document major and minor SDFormat version numbers (#1065)
2f13983 
Signed-off-by: Steve Peters <[email protected]>
@jennuine
Readme: Ignition -> Gazebo (#1080)
e9e9546 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from chapulina July 21, 2022 16:40
@jennuine jennuine self-assigned this Jul 21, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jul 21, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 21, 2022
scpeters
scpeters reviewed Jul 21, 2022
View reviewed changes
cmake/SearchForStuff.cmake Outdated
@@ -0,0 +1,152 @@
include (FindPkgConfig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we removed this SearchForStuff.cmake file when migrating to ign-cmake2. We don't want to re-add it. Let's try to figure out which pull request induced a change here and figure out how to apply that change elsewhere (probably the root CMakeLists.txt)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the changes were made in #1042

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9c81632

scpeters
scpeters requested changes Jul 21, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't add SearchForStuff.cmake

Core development automation moved this from Inbox to In review Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #1087 (514180c) into sdf12 (3dd02cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 514180c differs from pull request most recent head 9c81632. Consider uploading reports for the commit 9c81632 to get more accurate results

@@           Coverage Diff           @@
##            sdf12    #1087   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         109      109           
  Lines       16039    16043    +4     
=======================================
+ Hits        13837    13841    +4     
  Misses       2202     2202
Impacted Files Coverage Δ
src/Link.cc 98.57% <100.00%> (+0.03%) ⬆️
src/ign.cc 73.45% <100.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd02cc...9c81632. Read the comment docs.

@jennuine
9 ➡ 12
9c81632 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from scpeters July 21, 2022 20:56
@scpeters
Copy link
Member

thanks!

@scpeters scpeters merged commit d26860a into sdf12 Jul 22, 2022
Core development automation moved this from In review to Done Jul 22, 2022
@scpeters scpeters deleted the jennuine/9_to_12 branch July 22, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees

@jennuine jennuine

Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jennuine @scpeters @mabelzhang