Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completion for flags #1042

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Bash completion for flags #1042

merged 4 commits into from
Jun 15, 2022

Conversation

mabelzhang
Copy link
Collaborator

🎉 New feature

Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87

Summary

Bash completion, installation, tests.

Test it

$ . install/share/gz/gz1.completion
$ ign sdf -
--check           --describe        --force-version   --help            --inertial-stats  --print           --versions        -d                -h                -k                -p

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang mabelzhang added the OOBE 📦✨ Out-of-box experience label Jun 7, 2022
@mabelzhang mabelzhang added this to Inbox in Core development via automation Jun 7, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jun 7, 2022
src/cmd/CMakeLists.txt Outdated Show resolved Hide resolved
Core development automation moved this from Inbox to In review Jun 7, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pushed small fixes on 488d2ac:

@chapulina chapulina enabled auto-merge (squash) June 15, 2022 00:14
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1042 (0beddd2) into sdf9 (a428e2a) will increase coverage by 44.11%.
The diff coverage is n/a.

❗ Current head 0beddd2 differs from pull request most recent head 488d2ac. Consider uploading reports for the commit 488d2ac to get more accurate results

@@             Coverage Diff             @@
##             sdf9    #1042       +/-   ##
===========================================
+ Coverage   43.47%   87.59%   +44.11%     
===========================================
  Files           1       64       +63     
  Lines          23    10061    +10038     
===========================================
+ Hits           10     8813     +8803     
- Misses         13     1248     +1235     
Impacted Files Coverage Δ
test_config.h
src/Error.cc 100.00% <0.00%> (ø)
src/Console.cc 87.71% <0.00%> (ø)
src/Actor.cc 83.33% <0.00%> (ø)
src/Scene.cc 100.00% <0.00%> (ø)
src/Cylinder.cc 93.10% <0.00%> (ø)
include/sdf/Element.hh 100.00% <0.00%> (ø)
src/Camera.cc 81.16% <0.00%> (ø)
include/sdf/Filesystem.hh 100.00% <0.00%> (ø)
src/SDF.cc 92.26% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a428e2a...488d2ac. Read the comment docs.

@chapulina chapulina merged commit 9fc2e5f into sdf9 Jun 15, 2022
@chapulina chapulina deleted the mabelzhang/tab_completion branch June 15, 2022 00:39
Core development automation moved this from In review to Done Jun 15, 2022
@scpeters scpeters mentioned this pull request Jul 21, 2022
scpeters added a commit to gazebo-release/sdformat13-release that referenced this pull request Aug 3, 2022
chapulina pushed a commit to gazebo-release/sdformat13-release that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants