Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bash completion script #16

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Aug 3, 2022

@scpeters scpeters requested review from azeey and j-rivero August 3, 2022 23:40
@scpeters
Copy link
Contributor Author

scpeters commented Aug 3, 2022

@chapulina
Copy link
Contributor

Maybe all the CLI files should be installed in the non-dev package? See

@scpeters
Copy link
Contributor Author

scpeters commented Aug 5, 2022

Maybe all the CLI files should be installed in the non-dev package? See

I'd prefer to address that issue in a separate set of PRs since this is just trying to fix the unstable nightly build

@chapulina
Copy link
Contributor

I'd prefer to address that issue in a separate set of PRs since this is just trying to fix the unstable nightly build

Ok, I was trying to avoid the extra work, since fixing all the nightlies will involve lots of PRs to lots of versions and libraries. And then updating the package that it goes with will require another set of PRs to the same places.

By the way, @azeey is on this task already.

@chapulina chapulina merged commit c5dc077 into main Aug 5, 2022
@chapulina chapulina deleted the scpeters/install_bash_completion branch August 5, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants