Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heightmap physics (with DART) 🏔️ #661

Merged
merged 15 commits into from
Jul 17, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Closes #237

Summary

Add heightmap support to the physics system.

Requires gazebosim/gz-physics#218

There's a resolution issue still to be solved on the physics side. It looks like only red spheres can stay on top of the heightmap 😉 🔴

heightmap_dart)opt

Test it

Checklist

  • Signed all commits for DCO
  • Added tests: TODO
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added enhancement New feature or request physics Involves Ignition Physics needs upstream release Blocked by a release of an upstream library labels Mar 3, 2021
@chapulina chapulina requested a review from scpeters March 3, 2021 03:04
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 3, 2021
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Mar 17, 2021
@chapulina chapulina marked this pull request as ready for review March 17, 2021 21:05
@chapulina chapulina requested a review from azeey as a code owner March 17, 2021 21:05
@chapulina
Copy link
Contributor Author

This is ready for review. The heightmap behaves as expected when using the bullet collision checker:

heightmap_bullet

I tested the above with these branches:

@chapulina chapulina self-assigned this Mar 19, 2021
@chapulina chapulina removed the beta Targeting beta release of upcoming collection label Mar 24, 2021
@chapulina
Copy link
Contributor Author

Removed from beta, this can come in a minor release.

@chapulina chapulina changed the base branch from main to ign-gazebo5 April 1, 2021 20:37
@chapulina chapulina requested a review from iche033 as a code owner June 16, 2021 23:42
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any test, do you plan to add some ?

Some minor style improvements

examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
examples/worlds/heightmap.sdf Outdated Show resolved Hide resolved
@vatanaksoytezer
Copy link

Just for logging purposes, I've tested this PR with a source built fortress and had been able to reproduce the example and also use custom heightmaps with it. It seemed to work pretty well for me. The only down side seems to be is being stuck with ogre rather than ogre2, cross referencing gazebosim/gz-rendering#187 for more information.

@scpeters
Copy link
Member

we can test this branch with the ignition-physics4 prerelease if we merge the following: gazebo-tooling/gzdev#33

@scpeters
Copy link
Member

the Ignition-physics4 prerelease homebrew bottles are built, so I restarted the macOS job

chapulina and others added 2 commits July 15, 2021 18:30
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…tionrobotics/ign-gazebo into chapulina/5/heightmap_physics

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Jul 16, 2021
7 tasks
@chapulina chapulina dismissed ahcorde’s stale review July 16, 2021 21:09

Test added 👍

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 17, 2021
@chapulina chapulina merged commit d7741f6 into ign-gazebo5 Jul 17, 2021
@chapulina chapulina deleted the chapulina/5/heightmap_physics branch July 17, 2021 02:29
@chapulina chapulina mentioned this pull request Apr 22, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice enhancement New feature or request physics Involves Ignition Physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support heightmaps
5 participants