Skip to content

Gtdbtk update and make it actually work#7987

Open
bgruening wants to merge 4 commits into
galaxyproject:mainfrom
bgruening:gtdbtk
Open

Gtdbtk update and make it actually work#7987
bgruening wants to merge 4 commits into
galaxyproject:mainfrom
bgruening:gtdbtk

Conversation

@bgruening
Copy link
Copy Markdown
Member

We got the following error report:

usage: gtdbtk {de_novo_wf,classify_wf,identify,align,infer,classify,root,decorate,infer_ranks,ani_rep,test,trim_msa,remove_labels,convert_to_itol,convert_to_species,export_msa,check_install} ...
gtdbtk: error: unrecognized arguments: --skip_ani_screen

This PR updates the tool and removes the --skip_ani_screen

I used the following prompt to update the tool:

Details Please make a plan to update the Galaxy tool(s) in the tools/gtdbtk directory.
  • read the skills at /home/bag/.config/opencode/galaxy-skills/tool-dev/
  • make sure the latest conda recipe is used
  • all useful parameters are exposed in the Galaxy tool
  • uvx planemo lint is not exposing any errors or warning
  • uvx planemo test --biocontainers is passing

We also got this error that needs to be validated and fixed:

usage: gtdbtk {de_novo_wf,classify_wf,identify,align,infer,classify,root,decorate,infer_ranks,ani_rep,test,trim_msa,remove_labels,convert_to_itol,convert_to_species,export_msa,check_install} ...
gtdbtk: error: unrecognized arguments: --skip_ani_screen

adjustments

The --prefix is useless in the Galaxy context, as filenames do not get exposed to the user. This option could be used in the command section

@bgruening bgruening requested a review from bernt-matthias May 14, 2026 17:34
@bernt-matthias bernt-matthias mentioned this pull request May 18, 2026
5 tasks
Copy link
Copy Markdown
Contributor

@paulzierep paulzierep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove picrust2 commit from branch
  • Make place_species non optional (if tests work with the option its ok, but I could not make that work, seems like current DB logic needs it).
  • Update to new DB and mockDB see #7983

--prefix gtdbtk
--cpus "\${GALAXY_SLOTS:-4}"
--tmpdir tmp_dir
$advanced.place_species
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my test run, tool does not work without that param, similar to --skip_ani_screen

]]></command>
<inputs>
<param name="input" type="data" format="fasta,fasta.gz" multiple="true" label="Fasta (Genome) files"/>
<param name="gtdbtk_db" type="select" label="GTDB-Tk database" help="This version of GTDB-Tk requires GTDB version 226. Please contact your service administrator if this version is not available to select.">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version needs another DB: see #7983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants