Skip to content

SuperPMI: re-apply JitWasmNyiToR2RUnsupported when ignoring stored config #129026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyAyersMS wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

SuperPMI: re-apply JitWasmNyiToR2RUnsupported when ignoring stored config #129026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,6 +2280,17 @@ def replay_with_asm_diffs(self):
# two Release compilers, so this is safest.
flags += [ "-ignoreStoredConfig" ]

# `-ignoreStoredConfig` drops any codegenopt the collection recorded into the
# MCH stored config. For wasm we need to re-supply
# `JitWasmNyiToR2RUnsupported=1` (set by crossgen-corelib.proj during collection)
# so that unimplemented opcodes turn into R2R-unsupported skips rather than
# asserts. FIXME: remove once wasm codegen covers all cases.
if self.coreclr_args.target_arch == "wasm":
flags += [
"-jitoption", "force", "JitWasmNyiToR2RUnsupported=1",
"-jit2option", "force", "JitWasmNyiToR2RUnsupported=1"
]

# Change the working directory to the Core_Root we will call SuperPMI from.
# This is done to allow libcoredistools to be loaded correctly on unix
# as the loadlibrary path will be relative to the current directory.
Expand Down
Loading