SuperPMI: re-apply JitWasmNyiToR2RUnsupported when ignoring stored config#129026
Open
AndyAyersMS wants to merge 1 commit into
Open
SuperPMI: re-apply JitWasmNyiToR2RUnsupported when ignoring stored config#129026AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
…nfig The asmdiffs-checked-release leg uses -ignoreStoredConfig, which drops the JitWasmNyiToR2RUnsupported=1 setting that crossgen-corelib.proj recorded into the MCH stored config at collection time. The wasm JIT then asserts on unimplemented opcodes (e.g. GT_ASYNC_CONTINUATION) instead of cleanly skipping them as R2R-unsupported. Re-supply the option externally for wasm whenever we pass -ignoreStoredConfig. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@dotnet/wasm-contrib PTAL I also had to manually update the coredistools stored in our azure blob; for some reason these jobs fetch coredistools from the blob rather than copying the proper version from a build and/or fetching it via nuget. This should "really" be the last piece of Wasm SPMI infrastructure for now. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SuperPMI asm-diffs replay path to preserve a wasm-specific JIT behavior when -ignoreStoredConfig is used, by explicitly re-applying JitWasmNyiToR2RUnsupported=1 for wasm targets.
Changes:
- When
--diff_with_releasecauses-ignoreStoredConfigto be passed, add-jitoption force JitWasmNyiToR2RUnsupported=1and-jit2option force JitWasmNyiToR2RUnsupported=1fortarget_arch == "wasm".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The asmdiffs-checked-release leg uses -ignoreStoredConfig, which drops the JitWasmNyiToR2RUnsupported=1 recorded into the MCH stored config at collection time. The wasm JIT then asserts on unimplemented opcodes (e.g. GT_ASYNC_CONTINUATION) instead of cleanly skipping them as R2R-unsupported.
So add back the option externally for wasm whenever we pass -ignoreStoredConfig.
Fixes #129014