Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,7 @@ public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
try
{
using HttpResponseMessage response = await client.GetAsync(uri);
if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway)
if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway or HttpStatusCode.ServiceUnavailable)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would feel we can ignore any 500+ codes .... but simply adding the open we see is fine too.

{
// Ignore the erroneous status code, the test depends on an external server that is out of our control.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mark the tests as skipped or is it good enough we could talk to the server and get some answer back.

_output.WriteLine(response.ToString());
Expand Down
Loading