[HTTP] httpbin sometimes returns 503#128999
Open
ManickaP wants to merge 1 commit into
Open
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Jun 4, 2026
wfurt
reviewed
Jun 4, 2026
| { | ||
| using HttpResponseMessage response = await client.GetAsync(uri); | ||
| if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway) | ||
| if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway or HttpStatusCode.ServiceUnavailable) |
Member
There was a problem hiding this comment.
I would feel we can ignore any 500+ codes .... but simply adding the open we see is fine too.
wfurt
reviewed
Jun 4, 2026
| if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway) | ||
| if (response.StatusCode is HttpStatusCode.GatewayTimeout or HttpStatusCode.BadGateway or HttpStatusCode.ServiceUnavailable) | ||
| { | ||
| // Ignore the erroneous status code, the test depends on an external server that is out of our control. |
Member
There was a problem hiding this comment.
should we mark the tests as skipped or is it good enough we could talk to the server and get some answer back.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces flakiness in the HTTP remote-server decompression tests by treating occasional 503 ServiceUnavailable responses from the external httpbin.org/deflate endpoint as an ignorable transient failure (similar to existing handling for 502/504).
Changes:
- Extend the set of “ignore and return” HTTP status codes in the httpbin deflate decompression test to include
HttpStatusCode.ServiceUnavailable(503).
This was referenced Jun 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for httpbin returning 503, which is out of our control.
Based on Kusto, started 28.5., seen in #128940