Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-sigma] Update Sigma docs to use translator instance and container data classes #26800

Merged

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jan 3, 2025

Summary & Motivation

As title.

How I Tested These Changes

BK and docs preview

@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-sigma-asset-specs branch from 926c8de to 71ba208 Compare January 3, 2025 15:22
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-translator-instance branch from b2f3a08 to 3e02b3d Compare January 3, 2025 15:22
@maximearmstrong maximearmstrong self-assigned this Jan 3, 2025
@maximearmstrong maximearmstrong marked this pull request as ready for review January 3, 2025 15:29
@neverett neverett added the docs-to-migrate Docs to migrate to new docs site label Jan 3, 2025
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-sigma-asset-specs branch from 71ba208 to c090141 Compare January 3, 2025 17:49
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-translator-instance branch from 3e02b3d to 6401209 Compare January 3, 2025 17:49
Base automatically changed from maxime/use-translator-instance-in-load-sigma-asset-specs to master January 3, 2025 18:17
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-translator-instance branch from 6401209 to c416d7f Compare January 3, 2025 18:28
@maximearmstrong maximearmstrong merged commit b912cb4 into master Jan 3, 2025
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/update-sigma-docs-translator-instance branch January 3, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants