Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-sigma] Use Sigma translator instance in spec loader and state-backed defs #26799

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jan 3, 2025

Summary & Motivation

Same as #26734 but for Sigma.

How I Tested These Changes

BK

Changelog

[dagster-sigma] load_sigma_asset_specs is updated to accept an instance of DagsterSigmaTranslator or custom subclass.

@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-sigma branch from 3b8f8e8 to bda9718 Compare January 3, 2025 15:22
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-sigma-asset-specs branch from 926c8de to 71ba208 Compare January 3, 2025 15:22
@maximearmstrong maximearmstrong self-assigned this Jan 3, 2025
@maximearmstrong maximearmstrong marked this pull request as ready for review January 3, 2025 15:29
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it is here. can you add test for deprecation?

@maximearmstrong
Copy link
Contributor Author

ah it is here. can you add test for deprecation?

It is in test_asset_specs.py at line 128-131:

with pytest.warns(
    DeprecationWarning,
    match=r"Support of `dagster_sigma_translator` as a Type\[DagsterSigmaTranslator\]",
):
    ...     

Base automatically changed from maxime/move-translator-context-to-translator-props-class-sigma to master January 3, 2025 17:48
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-sigma-asset-specs branch from 71ba208 to c090141 Compare January 3, 2025 17:49
@maximearmstrong maximearmstrong merged commit cf8f623 into master Jan 3, 2025
1 check passed
@maximearmstrong maximearmstrong deleted the maxime/use-translator-instance-in-load-sigma-asset-specs branch January 3, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants