[dagster-sigma] Move contextual data from DagsterSigmaTranslator to container classes #26798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-qaggrb9ry-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-sigma
branch
from
3b8f8e8 to
bda9718
Compare
schrockn
requested changes
Jan 3, 2025
schrockn
approved these changes
Jan 3, 2025
Changing the type hint here doesn't break anything - it is required because In terms of user code, users will still pass the type here, not an instance. A deprecation warning is added in the subsequent PR, in which we allow passing an instance of the translator. |
maximearmstrong
deleted the
maxime/move-translator-context-to-translator-props-class-sigma
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Same as #26654 but for Sigma.
How I Tested These Changes
Updated tests with BK
Changelog
[dagster-sigma] Type hints in the signature of
DagsterLookerApiTranslator.get_asset_spechave been updated - the parameterdatais now of typeUnion[SigmaDatasetTranslatorData, SigmaWorkbookTranslatorData]instead ofUnion[SigmaDataset, SigmaWorkbook]. Custom Looker API translators should be updated.