Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[rocksdb]: fix error rocksdb default config for CFOptions #4466

Merged
merged 5 commits into from
Jul 20, 2024
Merged

fix[rocksdb]: fix error rocksdb default config for CFOptions #4466

merged 5 commits into from
Jul 20, 2024

Conversation

AuroraTwinkle
Copy link
Contributor

@AuroraTwinkle AuroraTwinkle commented Jul 19, 2024 •
edited
Loading

Descriptions of the changes in this PR:

Fix erros of rocksdb default config

Motivation

The default rocksdb config has some errors and need fix.

Changes

  1. Fix error rocksdb default config for CFOptions.
  2. Update rocksdb config for unit test

liangyepianzhou
liangyepianzhou approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@liangyepianzhou liangyepianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StevenLuMT
StevenLuMT approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, LGTM

@dlg99
Copy link
Contributor

dlg99 commented Jul 19, 2024

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

@AuroraTwinkle
Copy link
Contributor Author

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

Thanks，I will fix all failed Testcases.

@StevenLuMT StevenLuMT requested a review from dlg99 July 19, 2024 06:31
@AuroraTwinkle
Copy link
Contributor Author

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

I have fixed it.

@StevenLuMT StevenLuMT merged commit 4ca020a into apache:master Jul 20, 2024
23 checks passed
@lhotari lhotari mentioned this pull request Aug 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari left review comments

@dlg99 dlg99 dlg99 approved these changes

@StevenLuMT StevenLuMT StevenLuMT approved these changes

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@zymap zymap Awaiting requested review from zymap

@shoothzj shoothzj Awaiting requested review from shoothzj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AuroraTwinkle @dlg99 @lhotari @shoothzj @StevenLuMT @liangyepianzhou