Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[rocksdb]: fix error rocksdb default config for CFOptions #4466

Merged
merged 5 commits into from
Jul 20, 2024
Merged

fix[rocksdb]: fix error rocksdb default config for CFOptions #4466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cafd1f
fix[rocksdb]: fix error rocksdb default config for CFOptions
Jul 19, 2024
9f1608e
fix[rocksdb]: update rocksdb config for unit test
Jul 19, 2024
b2d4872
fix[doc]: add comments for rocksdb configuration files
Jul 19, 2024
0905f12
fix[test}: fix test cases
Jul 19, 2024
26ee64c
fix rocksdb config
Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions bookkeeper-server/src/test/resources/conf/default_rocksdb.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@
info_log_level=INFO_LEVEL
# set by jni: options.setKeepLogFileNum
keep_log_file_num=30

[CFOptions "default"]
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400
log_file_time_to_roll=86400

[CFOptions "default"]
#no default setting in CFOptions

[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setChecksumType
checksum=kxxHash
4 changes: 2 additions & 2 deletions bookkeeper-server/src/test/resources/conf/entry_location_rocksdb.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400
# set by jni: options.setMaxBackgroundJobs or options.setIncreaseParallelism
max_background_jobs=2
max_background_jobs=32
# set by jni: options.setMaxSubcompactions
max_subcompactions=1
# set by jni: options.setMaxTotalWalSize
Expand Down Expand Up @@ -57,7 +57,7 @@
[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setBlockSize
block_size=65536
# set by jni: tableOptions.setBlockCache
# set by jni: tableOptions.setBlockCache, default value is: maxDirectMemory() / ledgerDirsSize / 10;
block_cache=206150041
# set by jni: tableOptions.setFormatVersion
format_version=2
Expand Down
11 changes: 8 additions & 3 deletions bookkeeper-server/src/test/resources/conf/ledger_metadata_rocksdb.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@
info_log_level=INFO_LEVEL
# set by jni: options.setKeepLogFileNum
keep_log_file_num=30

[CFOptions "default"]
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400
log_file_time_to_roll=86400

[CFOptions "default"]
#no default setting in CFOptions

[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setChecksumType
checksum=kxxHash
22 changes: 21 additions & 1 deletion bookkeeper-server/src/test/resources/test_entry_location_rocksdb.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,22 @@
[DBOptions]
# set by jni: options.setCreateIfMissing
create_if_missing=true
# set by jni: options.setInfoLogLevel
info_log_level=INFO_LEVEL
# set by jni: options.setKeepLogFileNum
keep_log_file_num=1
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400
# set by jni: options.setMaxBackgroundJobs or options.setIncreaseParallelism
max_background_jobs=32
# set by jni: options.setMaxSubcompactions
max_subcompactions=1
# set by jni: options.setMaxTotalWalSize
max_total_wal_size=1000
# set by jni: options.setMaxOpenFiles
max_open_files=-1
# set by jni: options.setDeleteObsoleteFilesPeriodMicros
delete_obsolete_files_period_micros=3600000000

[CFOptions "default"]
# set by jni: options.setCompressionType
Expand All @@ -31,13 +43,21 @@
write_buffer_size=1024
# set by jni: options.setMaxWriteBufferNumber
max_write_buffer_number=1
# set by jni: options.setNumLevels
num_levels=7
# set by jni: options.setLevelZeroFileNumCompactionTrigger
level0_file_num_compaction_trigger=4
# set by jni: options.setMaxBytesForLevelBase
max_bytes_for_level_base=268435456
# set by jni: options.setTargetFileSizeBase
target_file_size_base=67108864
# set by jni: options.setLevelCompactionDynamicLevelBytes
level_compaction_dynamic_level_bytes=true

[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setBlockSize
block_size=65536
# set by jni: tableOptions.setBlockCache
# set by jni: tableOptions.setBlockCache, default value is: maxDirectMemory() / ledgerDirsSize / 10;
block_cache=206150041
# set by jni: tableOptions.setFormatVersion
format_version=2
Expand Down
9 changes: 7 additions & 2 deletions conf/default_rocksdb.conf.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,23 @@
# * limitations under the License.
# */

# When modifying this file, please also modify the configuration files(at
# bookkeeper-server/src/test/resources/conf) in the
# test case to ensure unit test coverage.

[DBOptions]
# set by jni: options.setCreateIfMissing
create_if_missing=true
# set by jni: options.setInfoLogLevel
info_log_level=INFO_LEVEL
# set by jni: options.setKeepLogFileNum
keep_log_file_num=30

[CFOptions "default"]
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400

[CFOptions "default"]
#no default setting in CFOptions

[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setChecksumType
checksum=kxxHash
8 changes: 6 additions & 2 deletions conf/entry_location_rocksdb.conf.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
# * limitations under the License.
# */

# When modifying this file, please also modify the configuration files(at
# bookkeeper-server/src/test/resources/conf) in the
# test case to ensure unit test coverage.

[DBOptions]
# set by jni: options.setCreateIfMissing
create_if_missing=true
Expand All @@ -26,7 +30,7 @@
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400
# set by jni: options.setMaxBackgroundJobs or options.setIncreaseParallelism
max_background_jobs=2
max_background_jobs=32
lhotari marked this conversation as resolved.
Show resolved Hide resolved
# set by jni: options.setMaxSubcompactions
max_subcompactions=1
# set by jni: options.setMaxTotalWalSize
Expand Down Expand Up @@ -57,7 +61,7 @@
[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setBlockSize
block_size=65536
# set by jni: tableOptions.setBlockCache
# set by jni: tableOptions.setBlockCache, default value is: maxDirectMemory() / ledgerDirsSize / 10;
block_cache=206150041
# set by jni: tableOptions.setFormatVersion
format_version=2
Expand Down
9 changes: 7 additions & 2 deletions conf/ledger_metadata_rocksdb.conf.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,22 @@
# * limitations under the License.
# */

# When modifying this file, please also modify the configuration files(at
# bookkeeper-server/src/test/resources/conf) in the
# test case to ensure unit test coverage.

[DBOptions]
# set by jni: options.setCreateIfMissing
create_if_missing=true
# set by jni: options.setInfoLogLevel
info_log_level=INFO_LEVEL
# set by jni: options.setKeepLogFileNum
keep_log_file_num=30

[CFOptions "default"]
# set by jni: options.setLogFileTimeToRoll
log_file_time_to_roll=86400

[CFOptions "default"]
#no default setting in CFOptions

[TableOptions/BlockBasedTable "default"]
# set by jni: tableOptions.setChecksumType
Expand Down