-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][misc] Set format_version=5, checksum=kxxHash in Bookkeeper RocksDB configs #23175
[improve][misc] Set format_version=5, checksum=kxxHash in Bookkeeper RocksDB configs #23175
Conversation
…ocksDB configs - also fix invalid CFOptions config
Could you explain the
|
@nodece The option is used for new database files. It won't prevent reading existing database files created with a previous format_version such as 2. The format_version setting is ignored for existing database files (new files created in compaction will get written with configured format_version). There's a problem in the current config files that format_version isn't set for |
Motivation
RocksDB format_version 5 has been supported since RocksDB 6.6 . It's required for certain performance optimizations.
Currently the default is format_version=2 which is really old. It's better to default to a more modern version.
Changes
format_version=5
andchecksum=kxxHash
in Bookkeeper RocksDB config filesmax_background_jobs
match pre-4.15 configuration for entry location db.Documentation
doc
doc-required
doc-not-needed
doc-complete