Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add population average FreeSurfer parcellation info to README #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhlegarreta
Copy link

@jhlegarreta jhlegarreta commented Jun 22, 2023

Add population average FreeSurfer parcellation information to README: add short explanation on how it was computed and a link to the corresponding NIfTI file hosted together with the rest of the data in zenodo.

@jhlegarreta jhlegarreta marked this pull request as draft June 22, 2023 19:27
@jhlegarreta
Copy link
Author

Waiting to see if we put this into where the rest of the population average data resides in Zenodo, and other computation details if relevant.

@jhlegarreta
Copy link
Author

@ljod will tag you once I get information on this from Fan and Yuqian, as I do not have merge rights.

@jhlegarreta
Copy link
Author

So the explanation I provided matches what Yuqian provided the only remaining this is eventually making the data available in Zenodo and pointing to it instead of the GitHub file.

@jhlegarreta jhlegarreta force-pushed the AddFSParcellationInfoToREADME branch from 5dafcba to a8b5c14 Compare June 22, 2023 22:11
Add population average `FreeSurfer` parcellation information to
`README`: add short explanation on how it was computed and a link to the
corresponding `NIfTI` file hosted together with the rest of the data in
`zenodo`.
@jhlegarreta jhlegarreta force-pushed the AddFSParcellationInfoToREADME branch from a8b5c14 to cec3be4 Compare June 26, 2023 15:49
@jhlegarreta jhlegarreta marked this pull request as ready for review June 26, 2023 15:49
@jhlegarreta
Copy link
Author

@ljod @zhangfanmark This is ready to be merged.

BTW, I noticed that throughout the README multiple versions/records of the data in zenodo are being used, which may be inaccurate/misleading, as the data in some records may have become deprecated/superseded by newer versions. So using a single link to the latest version of the record, and naming the necessary files for a purpose would avoid such issue. Let me know what you think and if you want me to propose this on a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant