Add data support in ament_index_share_files

[frneer]

This patch adds a data attribute, to support runtime files such as meshes that in bazel targets usually live in data rather than srcs.

---

This change is 

[frneer]

@calderpg-tri if you have time to take a quick look at it I'd appreciate it.

[julianadrianheine]

just left one small non-blocking nit/question.

@julianadrianheine made 2 comments.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on calderpg-tri and frneer).

---

bazel_ros2_rules/lib/ament_index.bzl line 102 at r1 (raw file):

            allow_files = True,
        ),
        data = attr.label_list(

nit: since both data and srcs are being handled exactly the same, it might be good to add a small note explaining what should go to each argument?

[frneer]

Nice question, you convinced me to take a different approach. PTAL

@frneer made 2 comments.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on calderpg-tri and julianadrianheine).

---

bazel_ros2_rules/lib/ament_index.bzl line 102 at r1 (raw file):

Previously, julianadrianheine (julianheine) wrote…

nit: since both data and srcs are being handled exactly the same, it might be good to add a small note explaining what should go to each argument?

Actually we don't strictly need to have a separate data attribute expose, including the runfiles should do it. Even though having data is the standard in bazel in this case I agree is more confusing than helpful.

[imcmahon-tri]

as well. Thanks!

@imcmahon-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on imcmahon-tri and julianadrianheine).

[frneer]

@frneer resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on frneer).

[hidmic]

Double stamped 😅