Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump astrojs/check #6165

Merged

Conversation

sileht
Copy link
Member

@sileht sileht commented Mar 5, 2025

astrojs now enforces the typechecking, so this change fixes the typing
everywhere.

Depends-On: #6138

sileht added 3 commits March 5, 2025 12:19
No need to have two frameworks.

Change-Id: I2841bff3a6b271fc3796eb63b8430da1e036bdc6
We have to enable the shiki highlighting mode and set a theme.

Fixes MRGFY-4834

Change-Id: I49affe940645f81f941f03e116d02c4896ff031e
astrojs now enforces the typechecking, so this change fixes the typing
everywhere.

Change-Id: I548a552d07996df5e1944bf13f6f4edc2b6fbd3a
This was referenced Mar 5, 2025
@sileht
Copy link
Member Author

sileht commented Mar 5, 2025

This pull request is part of a stack:

  1. chore(deps): drop preact (#6137)
  2. fix: syntax highlighting (#6138)
  3. chore(deps): bump astrojs/check (#6165) 👈
  4. chore(deps): update astro (#6166)

@sileht sileht mentioned this pull request Mar 5, 2025
Copy link
Contributor

mergify bot commented Mar 5, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 ⛓️ Depends-On Requirements

Wonderful, this rule succeeded.

Requirement based on the presence of Depends-On in the body of the pull request

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

Base automatically changed from devs/sileht/preact/I49affe940645f81f941f03e116d02c4896ff031e to main March 5, 2025 14:43
@sileht sileht closed this Mar 5, 2025
@sileht sileht reopened this Mar 5, 2025
@mergify mergify bot requested a review from a team March 5, 2025 14:46
mergify bot added a commit that referenced this pull request Mar 5, 2025
@mergify mergify bot added the queued label Mar 5, 2025
@mergify mergify bot merged commit caf9a64 into main Mar 5, 2025
10 checks passed
@mergify mergify bot deleted the devs/sileht/preact/I548a552d07996df5e1944bf13f6f4edc2b6fbd3a branch March 5, 2025 14:50
@mergify mergify bot removed the queued label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants