fix: syntax highlighting #6138
Merged
fix: syntax highlighting #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 ⛓️ Depends-On RequirementsWonderful, this rule succeeded.Requirement based on the presence of
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
AlexandreGaubert
previously approved these changes
Mar 5, 2025
sileht
force-pushed
the
devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6
branch
from
1b3f013 to
52ad6cd
Compare
sileht
force-pushed
the
devs/sileht/preact/I49affe940645f81f941f03e116d02c4896ff031e
branch
from
5f68c6e to
b37351b
Compare
mergify
bot
dismissed
AlexandreGaubert’s stale review
Pull request has been modified.
Syffe
previously approved these changes
Mar 5, 2025
No need to have two frameworks. Change-Id: I2841bff3a6b271fc3796eb63b8430da1e036bdc6
We have to enable the shiki highlighting mode and set a theme. Fixes MRGFY-4834 Change-Id: I49affe940645f81f941f03e116d02c4896ff031e
sileht
force-pushed
the
devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6
branch
from
52ad6cd to
8040911
Compare
sileht
force-pushed
the
devs/sileht/preact/I49affe940645f81f941f03e116d02c4896ff031e
branch
from
b37351b to
1c0572e
Compare
This was referenced Mar 5, 2025
Base automatically changed from
devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6
to
main
March 5, 2025 13:45
DouglasBlackwood
approved these changes
Mar 5, 2025
AlexandreGaubert
approved these changes
Mar 5, 2025
70 tasks
mergify
bot
deleted the
devs/sileht/preact/I49affe940645f81f941f03e116d02c4896ff031e
branch
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
astrojs now enforces the typechecking, so this change fixes the typing everywhere. Depends-On: #6138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to enable the shiki highlighting mode and set a theme.
Fixes MRGFY-4834
Depends-On: #6137