Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): drop preact #6137

Merged
merged 1 commit into from
Mar 5, 2025
Merged

chore(deps): drop preact #6137

merged 1 commit into from
Mar 5, 2025
+31 −783

Conversation

sileht
Copy link
Member

@sileht sileht commented Mar 4, 2025

No need to have two frameworks.

@sileht
Copy link
Member Author

sileht commented Mar 4, 2025 •
edited
Loading

This pull request is part of a stack:

  1. chore(deps): drop preact (#6137) 👈
  2. fix: syntax highlighting (#6138)
  3. chore(deps): bump astrojs/check (#6165)
  4. chore(deps): update astro (#6166)

@sileht sileht mentioned this pull request Mar 4, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team March 4, 2025 22:22
jd
jd previously requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't ask my why but there's a subtle change in the rendering at least here:
CleanShot 2025-03-05 at 09 10 21
The margin gets wrong

@sileht sileht force-pushed the devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6 branch from 1b3f013 to 52ad6cd Compare March 5, 2025 09:38
@sileht sileht mentioned this pull request Mar 5, 2025
Closed
@mergify mergify bot dismissed jd’s stale review March 5, 2025 09:39

Pull request has been modified.

@sileht
chore(deps): drop preact
8040911 
No need to have two frameworks.

Change-Id: I2841bff3a6b271fc3796eb63b8430da1e036bdc6
@sileht sileht force-pushed the devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6 branch from 52ad6cd to 8040911 Compare March 5, 2025 13:18
This was referenced Mar 5, 2025
Merged
Merged
@mergify mergify bot requested a review from a team March 5, 2025 13:20
@sileht sileht closed this Mar 5, 2025
@sileht sileht reopened this Mar 5, 2025
mergify bot added a commit that referenced this pull request Mar 5, 2025
@mergify
Merge of #6137
8253314
@mergify mergify bot mentioned this pull request Mar 5, 2025
Closed
70 tasks
@mergify mergify bot added the queued label Mar 5, 2025
@mergify mergify bot merged commit 041dd4a into main Mar 5, 2025
15 checks passed
@mergify mergify bot deleted the devs/sileht/preact/I2841bff3a6b271fc3796eb63b8430da1e036bdc6 branch March 5, 2025 13:45
@mergify mergify bot removed the queued label Mar 5, 2025
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
@sileht
fix: syntax highlighting (#6138)
219ad45 
We have to enable the shiki highlighting mode and set a theme.

Fixes MRGFY-4834

Depends-On: #6137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

@DouglasBlackwood DouglasBlackwood DouglasBlackwood approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sileht @jd @DouglasBlackwood