"Not enough comments" #607 patch #608
Conversation
Also added patch-1-notes.md
| @@ -50,6 +70,7 @@ public void printInteger(final int theInteger) { | |||
| */ | |||
| @Override | |||
| public void print() { | |||
| // throw an exception of type `UnsupportedOperationException` which takes the constant defined in `com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.Constants` called `COM_SERIOUSCOMPANY_BUSINESS_JAVA_FIZZBUZZ_PACKAGENAMINGPACKAGE_IMPL_PRINTERS_INTEGER_INTEGER_PRINTER_PRINT` which contains the string "com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.printers.IntegerIntegerPrinter.print()" | |||
|
Great! The new code will strictly adhere by the current industry standards. |
| private PrintStream out; | ||
| // create a FizBuzz objecct called `fb` |
There was a problem hiding this comment.
I notice that you mis-spelled "object" in this comment. Not sure if it's critical to fix now but might be worth adding a comment or a TODO for the next developer.
Otherwise LGTM
There was a problem hiding this comment.
"FizBuzz" was also misspelled by the way, this might cause some grammar & language checking tools to fail the status checks, so it's best to patch this ASAP
There was a problem hiding this comment.
Can we create a GitHub issue for this and link it to a ticket on Jira so we can put it on our Sprint board?
There was a problem hiding this comment.
We already patched this last sprint. I remember because we talked about if it should be capitalized or not in several of the standups. I have been looking for the jira ticket for the last half hour, but I can't find it... but I think I remember "object" being misspelt as "objct" last time and the issue was already supposedly corrected based on the jira being closed. But I can't seem to find where it got updated. Let me look through all my old Jira tickets to find it... Could it be possible the dev didn't commit it up or something along those lines? I recommend we have a meeting to figure out what happened to it. Someone create an invite for the whole team please.
|
Sorry to interrupt, but this pull request has been moved to #646 due to internal technical difficulties. Please move all conversation there. |
|
We need to re-open this. Too many comments. |
Sorry. I didn't see this comment before commenting. Someone needs to send out a notification in email for stuff like this or I won't see it. Is it on a confluence page somewhere? |
No description provided.