-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Not enough comments" #607 patch #608
Closed
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca6ec18
Update FizzBuzzTest.java
samrland 2d77fcc
Finished 5 files; worked on 2 files
samrland bdf387c
Things and other things
samrland 6478738
Finished NoFizzNoBuzzStrategy and Printers
samrland 1d7554c
Factories
samrland 1dd1970
Factories
samrland 6fe14bd
finished LoopCondition.java
samrland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that you mis-spelled "object" in this comment. Not sure if it's critical to fix now but might be worth adding a comment or a TODO for the next developer.
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"FizBuzz" was also misspelled by the way, this might cause some grammar & language checking tools to fail the status checks, so it's best to patch this ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create a GitHub issue for this and link it to a ticket on Jira so we can put it on our Sprint board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already patched this last sprint. I remember because we talked about if it should be capitalized or not in several of the standups. I have been looking for the jira ticket for the last half hour, but I can't find it... but I think I remember "object" being misspelt as "objct" last time and the issue was already supposedly corrected based on the jira being closed. But I can't seem to find where it got updated. Let me look through all my old Jira tickets to find it... Could it be possible the dev didn't commit it up or something along those lines? I recommend we have a meeting to figure out what happened to it. Someone create an invite for the whole team please.