-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Not enough comments" #607 patch #608
Closed
Closed
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca6ec18
Update FizzBuzzTest.java
samrland 2d77fcc
Finished 5 files; worked on 2 files
samrland bdf387c
Things and other things
samrland 6478738
Finished NoFizzNoBuzzStrategy and Printers
samrland 1d7554c
Factories
samrland 1dd1970
Factories
samrland 6fe14bd
finished LoopCondition.java
samrland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# patch-1 Notes | ||
|
||
This pull request be to fix issue #607. | ||
|
||
NOTE: This file be to be removed after all commenting be done. | ||
|
||
|
||
ANOTHER NOTE: | ||
"<...>" be used to skip through many empty directories. | ||
For example, | ||
"/src/<...>/impl" | ||
be used to direct the reader to | ||
/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl. | ||
|
||
Another example, | ||
"/resources/<...>/spring.xml" | ||
be used to direct the reader to | ||
/resources/assets/configuration/spring/dependencyinjection/configuration/spring.xml. | ||
|
||
## DONE! | ||
|
||
### /test/java | ||
|
||
- /test/java/FizzBuzzTest.java | ||
- /test/java/TestConstants.java (!) | ||
|
||
### /src/<...>/impl | ||
|
||
- /src/<...>/impl/Constants.java (!) | ||
- /src/<...>/impl/StandardFizzBuzz.java | ||
- /src/<...>/impl/Main.java | ||
|
||
#### /src/<...>/impl/printers | ||
|
||
- /src/<...>/impl/printers/IntegerIntegerPrinter.java | ||
|
||
#### /src/<...>/impl/factories | ||
|
||
- /src/<...>/impl/factories/NoFizzNoBuzzStrategyFactory.java | ||
|
||
#### /src/<...>/impl/strategies | ||
|
||
- /src/<...>/impl/strategies/NoFizzNoBuzzStrategy.java | ||
|
||
### /src/<...>/interfaces | ||
|
||
- /src/<...>/interfaces/FizzBuzz.java | ||
|
||
#### /src/<...>/interfaces/parameters | ||
|
||
- /src/<...>/interfaces/parameters/FizzBuzzUpperLimitParameter.java | ||
|
||
### /src/<...>/interfaces/printers | ||
|
||
- /src/<...>/interfaces/printers/DataPrinter.java | ||
- /src/<...>/interfaces/printers/StringPrinter.java | ||
- /src/<...>/interfaces/printers/IntegerPrinter.java | ||
|
||
## IN PROGRESS | ||
|
||
undefined |
18 changes: 18 additions & 0 deletions
18
...n/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/Constants.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,41 @@ | ||
// Constants.java | ||
// Constants | ||
|
||
// add to package com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl | ||
package com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl; | ||
|
||
/** | ||
* Constants | ||
*/ | ||
public class Constants { | ||
|
||
// create constant for message if an attempt was made to divide by zero called `AN_ATTEMPT_WAS_MADE_TO_DIVIDE_BY_ZERO` which contains the string "An attempt was made to divide by zero." | ||
public static final String AN_ATTEMPT_WAS_MADE_TO_DIVIDE_BY_ZERO = "An attempt was made to divide by zero."; | ||
// create constant for word "Buzz" called `BUZZ` | ||
public static final String BUZZ = "Buzz"; | ||
// create constant for name of method `com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.printers.IntegerIntegerPrinter.print` called `COM_SERIOUSCOMPANY_BUSINESS_JAVA_FIZZBUZZ_PACKAGENAMINGPACKAGE_IMPL_PRINTERS_INTEGER_INTEGER_PRINTER_PRINT` which containt the string "com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.printers.IntegerIntegerPrinter.print()" | ||
public static final String COM_SERIOUSCOMPANY_BUSINESS_JAVA_FIZZBUZZ_PACKAGENAMINGPACKAGE_IMPL_PRINTERS_INTEGER_INTEGER_PRINTER_PRINT = "com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.printers.IntegerIntegerPrinter.print()"; | ||
// create constant for word "Fizz" called `FIZZ` | ||
public static final String FIZZ = "Fizz"; | ||
// create constant for the line seperator called `LINE_SEPERATOR` which contains the string "line.seperator" | ||
public static final String LINE_SEPARATOR = "line.separator"; | ||
// create constant for the name of the loop component factory called `LOOP_COMPONENT_FACTORY` which contains the string "loopComponentFactory" | ||
public static final String LOOP_COMPONENT_FACTORY = "loopComponentFactory"; | ||
// create constant for SPRING_XML which contains the string "spring.xml" | ||
public static final String SPRING_XML = "spring.xml"; | ||
// create constant for STANDARD_FIZZ_BUZZ which contains the string "standardFizzBuzz" | ||
public static final String STANDARD_FIZZ_BUZZ = "standardFizzBuzz"; | ||
// create constant for message if the integers could not be compared called `THE_INTEGERS_COULD_NOT_BE_COMPARED` which contains the string "The integers could not be compared." | ||
public static final String THE_INTEGERS_COULD_NOT_BE_COMPARED = "The integers could not be compared."; | ||
// create constant for the default fizz buzz upper limit parameter value called `DEFAULT_FIZZ_BUZZ_UPPER_LIMIT_PARAMETER_VALUE` which contains the integer 100 | ||
public static final int DEFAULT_FIZZ_BUZZ_UPPER_LIMIT_PARAMETER_VALUE = 100; | ||
// create constant for the integer divided by zero value called `INTEGER_DIVIDE_ZERO_VALUE` which contains the integer 0 | ||
public static final int INTEGER_DIVIDE_ZERO_VALUE = 0; | ||
// create constant for the integer <origin?> zero value called `INTEGER_ORIGIN_ZERO_VALUE` which contains the integer 0 | ||
public static final int INTEGER_ORIGIN_ZERO_VALUE = 0; | ||
// create constant for the <i'm getting confused> | ||
public static final int LOOP_INC_VALUE = 1; | ||
// create constant for the <...> | ||
public static final int LOOP_INIT_VALUE = 1; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 17 additions & 2 deletions
19
...com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/StandardFizzBuzz.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments can be very long