Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional heuristic for template parsing handling multiple outputs #5157

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mwdchang
Copy link
Member

Summary

This address an incorrect assumption we made earlier that a transition's signature/key can be calculated from its input and output component, for the purpose of calculating transition groups. This is not the case, e.g we can have this scenario:

transition1_xx: [ input: [a], output: [b] }
transition2_yy: [ input: [a], output: [b] }

Where we would want to keep these transitions as different groups. To do this we add the base transition name as part of the key.

Testing

The model
pascale-strata-problem-templates.json, when loaded into Terarium should look like

image

Instead of:

image

Note the correct version should have 4 transition matrices instead of 3.

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang merged commit ad52b1c into main Oct 16, 2024
4 checks passed
@mwdchang mwdchang deleted the fix-mmt-ratelaw-parsing branch October 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants