Template transition matrices #5141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asylves1
commented
Oct 11, 2024
packages/client/hmi-client/src/model-representation/mira/mira.ts
Outdated
Show resolved
Hide resolved
asylves1
commented
Oct 11, 2024
packages/client/hmi-client/src/model-representation/mira/mira.ts
Outdated
Show resolved
Hide resolved
asylves1
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama and
blanchco
as code owners
YohannParis
reviewed
Oct 11, 2024
packages/client/hmi-client/src/model-representation/mira/mira.ts
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Oct 15, 2024
| } | ||
| }); | ||
| other.push(row); | ||
| }); |
There was a problem hiding this comment.
Calculation of 'others' seems slightly odd as it was an escape-hatch we made specifically for parameters, note templates - which should have regular-looking matrices.
Can we provide some additional background here on what this task is about?
|
I suspect this may not be needed anymore because of fixes in:
That address template parsing directly upstream of displaying the matrix modal. But let's keep this PR open for a few more days to confirm @asylves1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design Change:
Add dropdown options for the template matrix.
Testing:
Resolves #(issue)