extend MMT template-matrix to have subject-controller/subject-outcome configurations #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
requested review from
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
YohannParis
approved these changes
Oct 16, 2024
asylves1
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an addendum to #5157, addressing the model-diagram not rendering the correct matrix configurations. When controller is present we should use a subject-controller configuration instead of a suject-outcome configuration.
Testing
Load this given model
pascale-strata-problem-templates.json the model diagram should have 2 diagonal matrices and 2 full 3x3 matrices. Originally they were all diagonal matrices.
Note: there are known sympy parsing issues with this particular model. It will be dealt with separately as this touches our pyodide utilities and is out of scope w.r.t this PR.