-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change benchmark from tilt_sector
and input_tilt_sector
to tilt_subsector
and input_tilt_subsector
respectively
#799
Conversation
@maurolepore I can see that there are some workflows which are failing in Github Actions . Do I need to make any change in other packages as well for making this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kalashsinghal
-
ml01. I need a little time to see if we can instead remap "tsector" to "tilt_subsector". In principle it should be possible and simpler.
-
ml02. In the original issue by @Tilmon I see he refers only to
emissions_profile()
but this PR seems to also affectemissions_profile_upstream()
.
Yes, it does also affect |
Thanks @Tilmon It's actually less work to do it for both than for one indicator alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks @kalashsinghal.
I pushed a commit to revert the change to R/example_dictionary.R since that change is already in main
(9dc8e3a).
Note that @Tilmon confirmed that we need the same on the *upsteam indicator. Not sure if you need to follow up.
I experimiented a bit with the re-mapping of the alias but I think this PR is good to go.
Please remember to update NEWS or let me know when you merge and I'm happy to do it.
tilt_sector
to tilt_subsector
tilt_sector
and input_tilt_sector
to tilt_subsector
and input_tilt_subsector
respectively
tilt_sector
totilt_subsector
#797Dear @maurolepore,
As per the new requirement, we have to change the benchmark from
tilt_sector
andinput_tilt_sector
totilt_subsector
andinput_tilt_subsector
respectively. Please review this change asap. Thanks!cc @Tilmon @AnneSchoenauer
TODO