Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change benchmark from tilt_sector and input_tilt_sector to tilt_subsector and input_tilt_subsector respectively #799

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

kalashsinghal
Copy link
Collaborator

@kalashsinghal kalashsinghal commented Jun 25, 2024

Dear @maurolepore,

As per the new requirement, we have to change the benchmark from tilt_sector and input_tilt_sector to tilt_subsector and input_tilt_subsector respectively. Please review this change asap. Thanks!

cc @Tilmon @AnneSchoenauer


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR description to reflect what it ended up doing.
  • Polish the PR title as you'd like others to read it from the git log.
  • Assign a reviewer.
  • Document user-facing changes in the changelog.

@kalashsinghal
Copy link
Collaborator Author

@maurolepore I can see that there are some workflows which are failing in Github Actions . Do I need to make any change in other packages as well for making this change?

Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kalashsinghal

  • ml01. I need a little time to see if we can instead remap "tsector" to "tilt_subsector". In principle it should be possible and simpler.

  • ml02. In the original issue by @Tilmon I see he refers only to emissions_profile() but this PR seems to also affect emissions_profile_upstream().

  • ml03. See example_products() gains tilt_subsector #803

R/example_dictionary.R Outdated Show resolved Hide resolved
@maurolepore maurolepore mentioned this pull request Jun 25, 2024
12 tasks
@Tilmon
Copy link
Contributor

Tilmon commented Jun 25, 2024

@maurolepore

ml02. In the original issue by @Tilmon I see he refers only to emissions_profile() but this PR seems to also affect emissions_profile_upstream().

Yes, it does also affect emission_profile_upstream(), but we don't need this change now. We won't use upstream results right now. I.e., if implementing it for the emission_profile_upstream() costs extra time, we should leave it out for now and change it at a later stage. For now, we only need results for the indicators that are not upstream.

@maurolepore
Copy link
Contributor

Thanks @Tilmon

It's actually less work to do it for both than for one indicator alone.

Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks @kalashsinghal.

I pushed a commit to revert the change to R/example_dictionary.R since that change is already in main (9dc8e3a).

Note that @Tilmon confirmed that we need the same on the *upsteam indicator. Not sure if you need to follow up.

I experimiented a bit with the re-mapping of the alias but I think this PR is good to go.

Please remember to update NEWS or let me know when you merge and I'm happy to do it.

@kalashsinghal kalashsinghal changed the title Change benchmark from tilt_sector to tilt_subsector Change benchmark from tilt_sector and input_tilt_sector to tilt_subsector and input_tilt_subsector respectively Jun 26, 2024
@kalashsinghal kalashsinghal merged commit 1bc57dd into main Jun 26, 2024
8 checks passed
@kalashsinghal kalashsinghal deleted the 797_tilt_sector_to_tilt_subsector branch June 26, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change benchmark from tilt_sector to tilt_subsector
4 participants