Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-map *tsector to *tilt_subsector #804

Closed
wants to merge 2 commits into from

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Jun 25, 2024

This PR replaces all uses of the column tilt_sector with tilt_subsector. It replaces #797 which seems correct but this PR takes a different approach (re-mapping the alias) which profits from the indirection that aka() provides.

Also I take the chance to replace multiple instances of hard-coded column names with the more maintainable calls to aka() -- leaving the camp a lil cleaner than we found it.


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR description to reflect what it ended up doing.
  • Polish the PR title as you'd like others to read it from the git log.
  • Assign a reviewer.
  • Document user-facing changes in the changelog.

@maurolepore maurolepore force-pushed the map-tsector-to-tilt_subsector branch from 9eb9864 to 44ae4cc Compare June 25, 2024 17:33
@maurolepore
Copy link
Contributor Author

Closing in favor of #799

@maurolepore maurolepore deleted the map-tsector-to-tilt_subsector branch June 25, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change benchmark from tilt_sector to tilt_subsector
1 participant