Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example_products() gains tilt_subsector #803

Merged
merged 1 commit into from
Jun 25, 2024
Merged

example_products() gains tilt_subsector #803

merged 1 commit into from
Jun 25, 2024

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Jun 25, 2024 •
edited
Loading

This PR makes example_products() better reflect the corresponding dataset in tiltToyData.

  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR description to reflect what it ended up doing.
  • Polish the PR title as you'd like others to read it from the git log.
  • Assign a reviewer.
  • Document user-facing changes in the changelog.

@maurolepore maurolepore force-pushed the 801_example_products-gains-tilt_subsector branch from 7e53170 to 062f234 Compare June 25, 2024 13:35
@maurolepore maurolepore changed the title * example_products() gains tilt_sector example_products() gains tilt_sector Jun 25, 2024
@maurolepore maurolepore marked this pull request as ready for review June 25, 2024 13:38
@maurolepore maurolepore changed the title example_products() gains tilt_sector example_products() gains tilt_subsector Jun 25, 2024
@maurolepore maurolepore force-pushed the 801_example_products-gains-tilt_subsector branch from 062f234 to 64b2c82 Compare June 25, 2024 13:40
@maurolepore maurolepore merged commit c1f5a21 into main Jun 25, 2024
8 checks passed
@maurolepore maurolepore deleted the 801_example_products-gains-tilt_subsector branch June 25, 2024 13:40
@maurolepore maurolepore mentioned this pull request Jun 25, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example_products() needs tilt_subsector
1 participant
@maurolepore