Skip to content

test: Make home-page tests robust to changes in route animation duration #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 4, 2025
Merged

test: Make home-page tests robust to changes in route animation duration #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a72b60a
home test [nfc]: Move testNavObserver out to `main`
chrisbobbe Jun 3, 2025
9d66b9d
home test: Remove an unnecessary `tester.pump` for a route animation
chrisbobbe Jun 3, 2025
da39855
home test [nfc]: Move some `find.descendant`s
chrisbobbe Jun 3, 2025
b2cf41e
home test: Make tapOpenMenu stronger; rename with "AndAwait" to clarify
chrisbobbe Jun 4, 2025
d5960c7
home test: Add tapButtonAndAwaitTransition
chrisbobbe Jun 3, 2025
50e63ce
home test: Finish making menu tests robust to route animation changes
chrisbobbe Jun 3, 2025
cde7277
home test [nfc]: Name a helper more helpfully
chrisbobbe Jun 3, 2025
adeb828
home test: Make loading-page tests robust to route animation changes
chrisbobbe Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/test_navigation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@ import 'package:flutter/widgets.dart';

/// A trivial observer for testing the navigator.
class TestNavigatorObserver extends NavigatorObserver {
void Function(Route<dynamic> topRoute, Route<dynamic>? previousTopRoute)? onChangedTop;
void Function(Route<dynamic> route, Route<dynamic>? previousRoute)? onPushed;
void Function(Route<dynamic> route, Route<dynamic>? previousRoute)? onPopped;
void Function(Route<dynamic> route, Route<dynamic>? previousRoute)? onRemoved;
void Function(Route<dynamic>? route, Route<dynamic>? previousRoute)? onReplaced;
void Function(Route<dynamic> route, Route<dynamic>? previousRoute)? onStartUserGesture;
void Function()? onStopUserGesture;

@override
void didChangeTop(Route<dynamic> topRoute, Route<dynamic>? previousTopRoute) {
onChangedTop?.call(topRoute, previousTopRoute);
}

@override
void didPush(Route<dynamic> route, Route<dynamic>? previousRoute) {
onPushed?.call(route, previousRoute);
Expand Down
Loading
Loading