test: Make home-page tests robust to changes in route animation duration #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for some other tests.
This test doesn't need to check the widget tree after waiting for the route animation to complete. The navigator observer is alerted when the navigation action is dispatched, not when its animation completes, so it's fine to check pushedRoutes before waiting through the animation. (It still needs a Duration.zero wait so that a FakeApiConnection timer isn't still pending at the end of the test.)
This duplicates the `find.descendant`s in `tester.tap` callsites, but that's temporary; we'll deduplicate with a new helper function, coming up.
This is robust to changes in the entrance-animation duration, and it checks the state more thoroughly.
As in the previous commit, this removes some more hard-coding of route-animation durations.
This should fix all the failing tests in flutter/flutter#165832. Discussion: flutter/flutter#165832 (comment)
rajveermalviya
approved these changes
Jun 4, 2025
|
|
||
| final sheetPopDuration = (topRouteBeforePress as ModalBottomSheetRoute<void>) | ||
| .reverseTransitionDuration; | ||
| // TODO not sure why a 1ms fudge is needed; investigate. |
There was a problem hiding this comment.
Looks like the example provided upstream also has the same 1ms hack: flutter/flutter#165832 (comment).
Also the value of sheetPopDuration here turns out to be 200ms, different from the previous 250ms.
There was a problem hiding this comment.
I wonder if we tried 200ms when writing the test, but it failed for the same (unknown) reason it fails now, and we added 50ms to hack around instead of just 1ms.
rajveermalviya
removed
the
maintainer review
rajveermalviya
added
the
integration review
|
The CI failure is #1545; I have #1546 open for that. (That failure shouldn't affect the customer-tests run, because that's done with I'll go ahead and merge this and send a flutter/tests PR bumping the Zulip commit ID. Thanks for the review! Normally I wouldn't merge without Greg's review, but the changes are only in tests, Greg is OOO through Monday, and I'd like to unblock the upstream work. |
chrisbobbe
added a commit
to chrisbobbe/tests
that referenced
this pull request
Jun 4, 2025
…ration This updates to the following change in Zulip: zulip/zulip-flutter@834834b zulip/zulip-flutter#1547 in order to unblock this PR: flutter/flutter#165832
Piinks
pushed a commit
to chrisbobbe/tests
that referenced
this pull request
Jun 11, 2025
…ration This updates to the following change in Zulip: zulip/zulip-flutter@834834b zulip/zulip-flutter#1547 in order to unblock this PR: flutter/flutter#165832
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Jun 11, 2025
…ration (#460) This updates to the following change in Zulip: zulip/zulip-flutter@834834b zulip/zulip-flutter#1547 in order to unblock this PR: flutter/flutter#165832 > [!IMPORTANT] > This repository is a testing suite that contains references to tests (in the `registry` directory) that are run with every commit to Flutter > to verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is _not_ automatically run in the > Flutter CI tree. > > After merging this PR, you must send another PR to flutter/flutter updating `dev/customer_testing/tests.version` in that repo with the latest git commit SHA of the flutter/test repo. > > See <flutter/flutter#162048> for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix some tests to allow an upstream change to land.
Discussion; see Greg's comment: flutter/flutter#165832 (comment)
There are more places we use hard-coded durations, but those don't seem to be affected—the four test failures are all in
home_test.dart.