Fix Github edit links in top-right of HTML pages #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These links 404'd because they omitted the file suffix, and they didn't really link to anything editable, just the raw file.
|
yeah its annoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matti noticed that these links 404'd because they omitted the file suffix. This change uses a different variable name in Jinja to fix that, and also changes the target link to the editable sources instead the default source viewer.
There's an LTD test build here if you want to check it out: https://docs.zeek.org/en/topic-christian-test-fix-github-edit-link/
Once this goes in we need it twice more, for the Broker and zkg docs.