Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github edit links in top-right of HTML pages #379

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Nov 3, 2023

These links 404'd because they omitted the file suffix, and they didn't really link to anything editable, just the raw file.


Beadcrumbs were relying on suffix which was available through sphinx_rtd_theme, but removed with readthedocs/sphinx_rtd_theme@c984d08.

These links 404'd because they omitted the file suffix, and they didn't really
link to anything editable, just the raw file.
@ckreibich
Copy link
Member

This is the equivalent of zeek/zeek-docs#222.

@ckreibich ckreibich merged commit 98491e0 into master Nov 14, 2023
23 of 24 checks passed
@ckreibich ckreibich deleted the topic/awelzel/fix-github-edit-link branch November 14, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants