-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: euint256 and code generation #414
base: new-types
Are you sure you want to change the base?
Conversation
d45a3d7
to
3fe07cb
Compare
3d20ed1
to
cdd8b1c
Compare
b139212
to
abbe471
Compare
You forgot to update |
For instance, as of now, there is a security issue since you forgot to remove the |
abbe471
to
91e507e
Compare
ebe1481
to
5d21648
Compare
5d21648
to
ce690da
Compare
*/ | ||
export const SUPPORTED_BITS: number[] = [8, 16, 32, 64, 128, 256]; | ||
export function validateFHETypes(fheTypes: FheType[]): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this function useful?
bf7ed04
to
61dfb10
Compare
33dfef4
to
28a9fae
Compare
729dc05
to
d0b8196
Compare
{ | ||
type: 'Euint160', | ||
value: 7, | ||
supportedOperators: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why you didn't put the supportedOperators here and put it inside in the alias (Eaddress)? this structure seems confusing.
The FHEGas tracking utility function is broken since the The biggest flaw I think currently, is the In summary for types.ts : the backend related code (i.e Remember: this makes sense, because we decided that "equivalent" types such as |
This PR:
TFHE.sol
andImpl.sol
for greater control over operator/type matchingeuint256
euintXX
such asasEuint8(uint8 value)
(instead ofasEuint8(uint256 value)
)ebytesXX
)TFHEExecutorNoEvents.sol
to prevent security risks for deprecated types (euint4 for all operators and euint256 for several operators).new-types
(feature) branch.There are a few TODOs that need to be addressed in future PRs (autogenerate tests for
ebytesXX
, adding underflow/overflow tests, adding tests for ACL view functions + potentially forisInitialized
)