fix: fix

Author: PacificYield

contracts/codegen/common.ts

@@ -194,7 +194,7 @@ export function validateFHETypes(fheTypes: FheType[]): void {
       throw new Error(`Invalid FHE type: ${JSON.stringify(fheType)}`);
     }
 
-    // TODO: Add more validation checks
+    // TODO Add more validation checks
   });
 }
 

contracts/codegen/generateOverloads.ts

@@ -133,7 +133,7 @@ export const SUPPORTED_FUNCTIONS: SupportedFunctions = {
         const newIndex = Number(BigInt(index) + (rhsNumber % BigInt(lhs)));
         return newIndex >= bits.length ? '0' : bits[newIndex];
       });
-      return BigInt(`0b${r.filter((bit) => bit === '0' || bit === '1').join('')}`);
+      return BigInt(`0b${r.join('')}`);
     },
   },
   shr: {
@@ -144,7 +144,7 @@ export const SUPPORTED_FUNCTIONS: SupportedFunctions = {
         const newIndex = Number(BigInt(index) - (rhsNumber % BigInt(lhs)));
         return newIndex < 0 ? '0' : bits[newIndex];
       });
-      return BigInt(`0b${r.filter((bit) => bit === '0' || bit === '1').join('')}`);
+      return BigInt(`0b${r.join('')}`);
     },
   },
   rotl: {
@@ -156,7 +156,7 @@ export const SUPPORTED_FUNCTIONS: SupportedFunctions = {
         if (newIndex >= lhs) newIndex = newIndex % lhs;
         return bits[newIndex];
       });
-      return BigInt(`0b${r.filter((bit) => bit === '0' || bit === '1').join('')}`);
+      return BigInt(`0b${r.join('')}`);
     },
   },
   rotr: {
@@ -168,7 +168,7 @@ export const SUPPORTED_FUNCTIONS: SupportedFunctions = {
         if (newIndex < 0) newIndex = lhs + newIndex;
         return bits[newIndex];
       });
-      return BigInt(`0b${r.filter((bit) => bit === '0' || bit === '1').join('')}`);
+      return BigInt(`0b${r.join('')}`);
     },
   },
   max: {
@@ -247,9 +247,12 @@ export const generateOverloads = (fheTypes: FheType[]) => {
               const bitResults = Math.min(lhsFheType.bitLength, rhsFheType.bitLength);
               let lhsNumber = generateRandomNumber(lhsFheType.bitLength);
               let rhsNumber = generateRandomNumber(rhsFheType.bitLength);
+
               if (test.limit === 'bits') {
-                rhsNumber = BigInt(1 + Math.floor(Math.random() * (rhsFheType.bitLength - 1)));
+                // @dev We set the floor as 5 to prevent underflows since tests would use smallest - 4n.
+                rhsNumber = BigInt(5 + Math.floor(Math.random() * (rhsFheType.bitLength - 1)));
               }
+
               const smallest = findMinimumValueInBigIntArray(lhsNumber, rhsNumber);
               const only8bits = test.limit === 'bits' && rhsFheType.bitLength === 8;
 

contracts/codegen/overloads.json

@@ -42,20 +42,12 @@ export function generateSolidityOverloadTestFiles(operators: Operator[], fheType
     });
   });
 
-  // Generate overloads for ternary operator (i.e., select) for all supported types
-  // TODO: test select
-
   // Generate overloads unary operators for all supported types.
   adjustedFheTypes.forEach((fheType: FheType) =>
     generateOverloadsForTFHEUnaryOperators(fheType, operators, signatures),
   );
 
-  // Generate overloads for conversion from plaintext and einput to all supported types (e.g., einput --> ebool, bytes memory --> ebytes64, uint32 --> euint32)
-  // TEST casting
-
-  // Generate overloads for rand/randBounded for all supported types
-  // Test randomness
-
+  // TODO Add tests for conversion from plaintext and einput to all supported types (e.g., einput --> ebool, bytes memory --> ebytes64, uint32 --> euint32)
   return signatures;
 }
 

contracts/codegen/testgen.ts

@@ -33,11 +33,12 @@ export const findMaximumValueInBigIntArray = (...args: bigint[]) => {
  * Generates a random number within a specified bit range.
  *
  * @param bits - The number of bits to determine the range of the generated number.
- * @returns A random BigInt number within the range defined by the number of bits.
+ * @param minValue - The minimum value to return.
+ * @returns A random BigInt number within the range defined by the number of bits and at least minValue.
  */
-export const generateRandomNumber = (bits: number) => {
+export const generateRandomNumber = (bits: number, minValue: bigint = 10n) => {
   const power = BigInt(Math.pow(2, bits) - 1);
   const maxRange = findMinimumValueInBigIntArray(power, BigInt(Number.MAX_SAFE_INTEGER));
-  const subtract = findMaximumValueInBigIntArray(BigInt(Math.floor(Math.random() * Number(maxRange))), 1n);
-  return findMaximumValueInBigIntArray(power - subtract, 1n);
+  const subtract = findMaximumValueInBigIntArray(BigInt(Math.floor(Math.random() * Number(maxRange))), minValue);
+  return findMaximumValueInBigIntArray(power - subtract, minValue);
 };