Skip to content

add trace_id to goroutine context #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

add trace_id to goroutine context #3620

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcb2548
- add trace_id to goroutine context
greeshma1196 Sep 10, 2025
7a0e15b
- to test: set the label to the request context
greeshma1196 Sep 11, 2025
3cc5464
Merge branch 'master' into proxy/add_trace_id
greeshma1196 Sep 11, 2025
8d6e67c
- fix check-fmt error
greeshma1196 Sep 11, 2025
9d6f218
- removed debug statement to pass test
greeshma1196 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proxy/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ type context struct {
logger filters.FilterContextLogger
proxyWatch stopWatch
proxyRequestLatency time.Duration
goCtx *stdlibcontext.Context
}

type filterMetrics struct {
Expand Down
17 changes: 17 additions & 0 deletions proxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"net/url"
"os"
"runtime"
"runtime/pprof"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -1200,6 +1201,8 @@ func (p *Proxy) do(ctx *context, parentSpan ot.Span) (err error) {
err = perr
}
}()
traceIDCtx, _ := pprof.Label(*ctx.goCtx, "trace_id")
ctx.Logger().Debugf("trace id in goroutine context: %s", traceIDCtx)

if ctx.executionCounter > p.maxLoops {
// TODO(sszuecs): think about setting status code to 463 or 465 (check what AWS ALB sets for redirect loop) or similar
Expand Down Expand Up @@ -1640,6 +1643,20 @@ func (p *Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ctx.initialSpan = span
ctx.parentSpan = span

traceID := tracing.GetTraceID(span)

gCtx := stdlibcontext.Background()

defer pprof.SetGoroutineLabels(gCtx)
labels := pprof.Labels("trace_id", traceID)
gCtx = pprof.WithLabels(gCtx, labels)
pprof.SetGoroutineLabels(gCtx)

ctx.goCtx = &gCtx

traceIDCtx, _ := pprof.Label(gCtx, "trace_id")
ctx.Logger().Debugf("trace id in goroutine context: %s", traceIDCtx)
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to store ctx.goCtx, i.e. just do:

labels := pprof.Labels("trace_id", tracing.GetTraceID(span))
pprof.SetGoroutineLabels(pprof.WithLabels(stdlibcontext.Background(), labels))
defer pprof.SetGoroutineLabels(stdlibcontext.Background())

From https://pkg.go.dev/runtime/pprof#SetGoroutineLabels we read

SetGoroutineLabels sets the current goroutine's labels to match ctx. A new goroutine inherits the labels of the goroutine that created it.

So to test this we can create a testproxy with a mock tracer and a test filter that spawns a goroutine and verifies it can obtain trace_id via https://pkg.go.dev/runtime/pprof#Label. See TestFilterPanic for how to create and register a test filter.


defer func() {
if ctx.response != nil && ctx.response.Body != nil {
err := ctx.response.Body.Close()
Expand Down
Loading