add trace_id to goroutine context #3620
Draft
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greeshma1196
added
tracing
proxy/proxy.go
Outdated
Comment on lines
1646
to
1658
| traceID := tracing.GetTraceID(span) | ||
|
|
||
| gCtx := stdlibcontext.Background() | ||
|
|
||
| defer pprof.SetGoroutineLabels(gCtx) | ||
| labels := pprof.Labels("trace_id", traceID) | ||
| gCtx = pprof.WithLabels(gCtx, labels) | ||
| pprof.SetGoroutineLabels(gCtx) | ||
|
|
||
| ctx.goCtx = &gCtx | ||
|
|
||
| traceIDCtx, _ := pprof.Label(gCtx, "trace_id") | ||
| ctx.Logger().Debugf("trace id in goroutine context: %s", traceIDCtx) |
There was a problem hiding this comment.
I think we don't need to store ctx.goCtx, i.e. just do:
labels := pprof.Labels("trace_id", tracing.GetTraceID(span))
pprof.SetGoroutineLabels(pprof.WithLabels(stdlibcontext.Background(), labels))
defer pprof.SetGoroutineLabels(stdlibcontext.Background())From https://pkg.go.dev/runtime/pprof#SetGoroutineLabels we read
SetGoroutineLabels sets the current goroutine's labels to match ctx. A new goroutine inherits the labels of the goroutine that created it.
So to test this we can create a testproxy with a mock tracer and a test filter that spawns a goroutine and verifies it can obtain trace_id via https://pkg.go.dev/runtime/pprof#Label. See TestFilterPanic for how to create and register a test filter.
Signed-off-by: Greeshma Mathew <[email protected]>
Signed-off-by: greeshma1196 <[email protected]>
Signed-off-by: greeshma1196 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #3596