suppress health check noise #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses logging of the Skipper health check path in normal conditions, reducing log noise. The logging is enabled if the health check fails or debugging levels are enabled Signed-off-by: Samuel Lang <[email protected]>
universam1
force-pushed
the
stopHealthNoise
branch
from
e70c464 to
4bc5c52
Compare
|
👍 |
Comment on lines
+352
to
+364
| logFilters := []*eskip.Filter{{ | ||
| Name: builtin.StatusName, | ||
| Args: []interface{}{http.StatusOK}}, | ||
| } | ||
| if !healthy { | ||
| status = http.StatusServiceUnavailable | ||
| logFilters[0].Args = []interface{}{http.StatusServiceUnavailable} | ||
| } | ||
| // log if unhealthy or a debug loglevel | ||
| if healthy && !log.IsLevelEnabled(log.DebugLevel) { | ||
| logFilters = append(logFilters, &eskip.Filter{ | ||
| Name: accesslog.DisableAccessLogName, | ||
| Args: []interface{}{200}, | ||
| }) |
There was a problem hiding this comment.
An alternative could be
var healthcheckFilters []*eskip.Filter
if healthy {
if log.IsLevelEnabled(log.DebugLevel) {
healthcheckFilters, _ = eskip.ParseFilters(`status(200)`)
} else {
healthcheckFilters, _ = eskip.ParseFilters(`disableAccessLog(200) -> status(200)`)
}
} else {
healthcheckFilters, _ = eskip.ParseFilters(`status(503)`)
}adjusted test
diff --git a/dataclients/kubernetes/kube_test.go b/dataclients/kubernetes/kube_test.go
index cd899715..8a3e60f1 100644
--- a/dataclients/kubernetes/kube_test.go
+++ b/dataclients/kubernetes/kube_test.go
@@ -410,10 +410,11 @@ func checkHealthcheck(t *testing.T, got []*eskip.Route, expected, healthy, rever
return
}
- if healthy && f.Args[0] != http.StatusOK {
- t.Error("invalid healthcheck status", f.Args[0], http.StatusOK)
- } else if !healthy && f.Args[0] != http.StatusServiceUnavailable {
- t.Error("invalid healthcheck status", f.Args[0], http.StatusServiceUnavailable)
+ status := int(f.Args[0].(float64))
+ if healthy && status != http.StatusOK {
+ t.Error("invalid healthcheck status", status, http.StatusOK)
+ } else if !healthy && status != http.StatusServiceUnavailable {
+ t.Error("invalid healthcheck status", status, http.StatusServiceUnavailable)
}
returnThere was a problem hiding this comment.
This parsing functionality is awesome to know!
My personal preference is to use static type compiler support whenever possible, not sure how expensive runtime parsing is but I’d expect a magnitude!?
There was a problem hiding this comment.
It is more about readabilty, skipper parses hundreds of routes on route table update anyway.
There was a problem hiding this comment.
We normally don’t parse filters like this in the dataclient if it’s not eskip or inline route
aryszka
reviewed
Dec 14, 2020
| @@ -348,9 +349,19 @@ func shuntRoute(r *eskip.Route) { | |||
| } | |||
|
|
|||
| func healthcheckRoute(healthy, reverseSourcePredicate bool) *eskip.Route { | |||
| status := http.StatusOK | |||
| logFilters := []*eskip.Filter{{ | |||
There was a problem hiding this comment.
i think we can also call logFilters as just filters, because their main gig is not the logging part but the status.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change suppresses logging of the Skipper health check path in normal conditions, reducing log noise.
The logging is enabled if the health check fails or debugging levels are enabled