dataclients/kubernetes: use healthcheck based on Shutdown predicate #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -470,7 +446,7 @@ func (c *Client) LoadUpdate() ([]*eskip.Route, []string, error) { | |||
| // TODO: use eskip.Eq() | |||
| if r, ok := next[id]; ok && r.String() != c.current[id].String() { | |||
| updatedRoutes = append(updatedRoutes, r) | |||
| } else if !ok && id != healthcheckRouteID && id != httpRedirectRouteID { | |||
| } else if !ok { | |||
There was a problem hiding this comment.
Since healthcheck and globalredirect routes are all static we can move them into loadAndConvert() and simplify update diff logic.
There was a problem hiding this comment.
Special handling of healthcheck route had caused problems in the past.
Previously healthcheck route was added to updatedRoutes after loadAndConvert() and until the #618 it happened on every poll cycle which caused constant routing table recreation #614 (comment)
Static healthcheck and globalredirect routes means they do not change after initial LoadAll() and therefore will not end up neither in updatedRoutes nor in deletedIDs. They are also treated just like normal routes which simplifies the overall code flow.
AlexanderYastrebov
force-pushed
the
kube-shutdown-healthcheck
branch
2 times, most recently
from
83b0424 to
0078558
Compare
szuecs
reviewed
Dec 1, 2021
szuecs
reviewed
Dec 1, 2021
Updates #1899 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
kube-shutdown-healthcheck
branch
from
0078558 to
5c15583
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1899
Signed-off-by: Alexander Yastrebov [email protected]